Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChunichiShimbun and TokyoShimbun #683

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Add ChunichiShimbun and TokyoShimbun #683

merged 5 commits into from
Jan 16, 2025

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Jan 13, 2025

No description provided.

@MaxDall MaxDall requested a review from addie9800 January 13, 2025 17:15
addie9800
addie9800 requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these as well 👍

src/fundus/publishers/jp/tokyo_chunichi_shimbun.py Outdated Show resolved Hide resolved
src/fundus/publishers/jp/tokyo_chunichi_shimbun.py Outdated Show resolved Hide resolved
src/fundus/publishers/jp/tokyo_chunichi_shimbun.py Outdated Show resolved Hide resolved
src/fundus/publishers/jp/tokyo_chunichi_shimbun.py Outdated Show resolved Hide resolved
src/fundus/publishers/jp/tokyo_chunichi_shimbun.py Show resolved Hide resolved
@MaxDall MaxDall requested a review from addie9800 January 14, 2025 15:05
addie9800
addie9800 previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed two more minor issues and took the liberty of fixing them. I hope that's OK with you. The author_selector needed to be modified since everything that is selected in the caption is removed. Looks good to me though 👍

Base automatically changed from add-asahi-shimbun to master January 16, 2025 11:35
@MaxDall MaxDall dismissed addie9800’s stale review January 16, 2025 11:35

The base branch was changed.

@MaxDall
Copy link
Collaborator Author

MaxDall commented Jan 16, 2025

I noticed two more minor issues and took the liberty of fixing them. I hope that's OK with you. The author_selector needed to be modified since everything that is selected in the caption is removed. Looks good to me though 👍

Of course 👍 Thanks for doing that!

@MaxDall MaxDall merged commit 9f1ecda into master Jan 16, 2025
5 checks passed
@MaxDall MaxDall deleted the add-tokyo-shimbun branch January 16, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addie9800 addie9800 addie9800 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDall @addie9800